New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not throw on invalid Vimeo id, render hint instead #55

Merged

bezoerb merged 1 commit into main from feat/improve-vimeo-template

Dec 22, 2022

Member

psolbach commented Dec 22, 2022 •

edited

Loading

This prevents builds from throwing an error and failing on invalid Vimeo source URLs entered in the CMS. Instead, we render an error message to clearly indicate what went wrong. We achieve this by ignoring the Hugo error on GET ("error-remote-getjson") and adding a statement to the embed template.


          feat(embed-vimeo): do not throw on invalid Vimeo id, render hint instead

5f07ed6

psolbach requested a review from bezoerb

December 22, 2022 10:50

sonarqubecloud bot commented Dec 22, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

psolbach mentioned this pull request

Make Vimeo embed logic more robust #54

Closed

bezoerb approved these changes

View reviewed changes

Member

bezoerb left a comment

LGTM

bezoerb merged commit 07049da into main

bezoerb deleted the feat/improve-vimeo-template branch

December 22, 2022 22:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet